New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: record sampling bug and add test #18

Merged

pnadolny13 merged 2 commits into main from bugfix-limit-sampling

Apr 17, 2023

Contributor

pnadolny13 commented Apr 17, 2023

Closes #16

adds setting infer_schema_sample_size to configure the amount of sample records to retrieve, defaults to 100
fixes bug where iterating didnt stop after limit was reached
test to assert limit works
refresh readme with updated settings

pnadolny13 added 2 commits

April 17, 2023 18:41


          fix record sampling bug and add test

fbda464


          fix failing integration test and pass sample size explictly

9c525b4

pnadolny13 merged commit 442a431 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet