Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: planet scale working #45

Merged
merged 26 commits into from
Feb 23, 2024
Merged

feat: planet scale working #45

merged 26 commits into from
Feb 23, 2024

Conversation

visch
Copy link
Member

@visch visch commented Feb 16, 2024 •
edited
Loading

Closes #22

@visch visch mentioned this pull request Feb 17, 2024
Closed
@visch
Copy link
Member Author

visch commented Feb 17, 2024

Need to cleanup the code to pass linting, also want to fix whatever is causing pytest not to run for this MR.

@visch visch changed the title WIP Discovery working, need to get tables working, and then refactor Draft: planet scale working Feb 18, 2024
@visch visch changed the title Draft: planet scale working feat: planet scale working Feb 19, 2024
@visch visch marked this pull request as ready for review February 21, 2024 05:01
visch
visch commented Feb 21, 2024
View reviewed changes
tap_mysql/client.py Outdated Show resolved Hide resolved
tap_mysql/client.py Show resolved Hide resolved
@visch visch mentioned this pull request Feb 21, 2024
Open
@visch visch mentioned this pull request Feb 22, 2024
Closed
edgarrmondragon
edgarrmondragon reviewed Feb 22, 2024
View reviewed changes
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tap_mysql/client.py Outdated Show resolved Hide resolved
tap_mysql/client.py Show resolved Hide resolved
tap_mysql/client.py Show resolved Hide resolved
visch and others added 4 commits February 22, 2024 15:35
@visch
Fix sqlalchemy_options documentation
f7520c9
@visch
Fix vitess config check
6c0e974
@visch @edgarrmondragon
Update README.md
fa8ac91 
Co-authored-by: Edgar Ramírez Mondragón <16805946+edgarrmondragon@users.noreply.github.com>
@visch @edgarrmondragon
Update README.md
7e2a11b 
Co-authored-by: Edgar Ramírez Mondragón <16805946+edgarrmondragon@users.noreply.github.com>
@edgarrmondragon edgarrmondragon merged commit ed33058 into main Feb 23, 2024
9 checks passed
@edgarrmondragon
Copy link
Member

Thanks @visch!

@edgarrmondragon edgarrmondragon deleted the planet_scale branch February 23, 2024 20:29
@visch
Copy link
Member Author

visch commented Feb 23, 2024

Thanks @visch!

No, thank you sir! I appreciate the great review :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test with PlanetScale
2 participants
@visch @edgarrmondragon