-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new EventEffect - moves the target agents into specified state #111
Adds new EventEffect - moves the target agents into specified state #111
Conversation
dff5a62
to
a25b7e7
Compare
a25b7e7
to
1da07b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits
Reviewed 13 of 13 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @curds01)
src/Menge/MengeCore/Agents/Events/change_state_effect.h, line 22 at r1 (raw file):
/** @file change_state_effect.h @brief The definitin of event effect that moves the target agents to a new state.
BTW typo: definition
src/Menge/MengeCore/Agents/Events/change_state_effect.h, line 83 at r1 (raw file):
protected: /** @brief Implements EventEffectFactory::setFromXML(). */ bool setFromXML(EventEffect * effect, TiXmlElement * node,
nit: new style Class*
src/Menge/MengeCore/Agents/Events/change_state_effect.h, line 89 at r1 (raw file):
EventEffect * instance() const override { return new ChangeStateEffect(); } /** @brief The identifier for the "state" string attribute. */
nit: tabs
- Adds the new EventEffect - Adds an example to exercise that feature. - Updates release notes.
1da07b5
to
f5e893a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @curds01)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @curds01)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
This builds on top of #110. This needs rebasing after that PR merges.
The new EventEffect comes with an example and a dedicated README.md discussing the example.
This change is