Skip to content
This repository has been archived by the owner on Nov 13, 2022. It is now read-only.

switch http libraries and add support for Client-Name header #91

Merged
merged 4 commits into from
Apr 1, 2021
Merged

switch http libraries and add support for Client-Name header #91

merged 4 commits into from
Apr 1, 2021

Conversation

viztea
Copy link
Collaborator

@viztea viztea commented Mar 27, 2021

2d0fe42
  • Switches from axios to petitio
  • Adds Node#makeRequest for easy API calls.
  • Adds NodeOptions#requestTimeout
74c2ef6
  • Adds ManagerOptions#clientName for use in the Client-Name header

Copy link
Member

@Strandxo Strandxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change of http library is a great idea.

@acollierr17
Copy link
Contributor

Hey, do you mind dropping a few bullet points on why you changed http libraries? Specifically to petitio?

Most people may overlook this change, but for guys/gals like me and you, knowing that information is valuable!

@viztea
Copy link
Collaborator Author

viztea commented Mar 29, 2021

Hey, do you mind dropping a few bullet points on why you changed http libraries? Specifically to petitio?

Most people may overlook this change, but for guys/gals like me and you, knowing that information is valuable!

I thought it might help with some timeout issues when loading tracks. This PR adds things that are still beneficial to erela regardless of the HTTP client being used.

Copy link
Contributor

@acollierr17 acollierr17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all checks out to me. Especially with the addition of the Node#makeRequest method along with petitio cleaning up the Manager class quite a bit.

Copy link
Member

@JonasSchiott JonasSchiott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from here. Nice job! ;)

@acollierr17 acollierr17 merged commit f0bd285 into MenuDocs:master Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants