Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace underscore with hyphen in article file names and reduce fixture file size #169

Merged
merged 6 commits into from
Mar 6, 2023

Conversation

nanxstats
Copy link
Collaborator

Fixes #168
Fixes #121

Vignettes:

  • Replace underscores (_) with hyphens (-) in vignettes file names.
  • Removed vignettes/articles/figures/readme.PNG as it's not being used anywhere.
  • Replace underscores (_) with hyphens (-) for files under vignettes/articles/figures/.
  • Update _pkgdown.yml so the articles can build.

Fixtures:

  • Re-save data under vignettes/articles/fixtures/. I kept the underscores in the file names following the R Packages book examples.
    • Use the RDS format instead of the RDA format and with xz compression: saveRDS(..., file = "*.rds", compress = "xz").
    • This will make the data more portable (loading without polluting the global environment) and reduce directory size from 66.4MB to 25.2MB.
  • Fix the R CMD check note on directory too large by adding a rule to exclude all .html files under inst/check_with_old_version/ to .Rbuildignore.

@nanxstats nanxstats requested a review from LittleBeannie March 3, 2023 00:29
@nanxstats
Copy link
Collaborator Author

@LittleBeannie ready for your review 💯

Not sure why the GitHub Actions workflows are not triggered, but it builds ok locally.

Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge scale changes!

@LittleBeannie LittleBeannie merged commit 9bfc991 into main Mar 6, 2023
@nanxstats nanxstats deleted the hyphens branch March 6, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace underscores with hyphens in vignettes file names Alternative approach to storing large data files
2 participants