Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update lf in fixed_design #211

Merged
merged 11 commits into from
Apr 16, 2023
Merged

update lf in fixed_design #211

merged 11 commits into from
Apr 16, 2023

Conversation

LittleBeannie
Copy link
Collaborator

No description provided.

@LittleBeannie LittleBeannie linked an issue Apr 14, 2023 that may be closed by this pull request
gsDesign vs fixed_design with lf #207
Closed
@LittleBeannie LittleBeannie self-assigned this Apr 14, 2023
@LittleBeannie LittleBeannie added the bug Something isn't working label Apr 14, 2023
@LittleBeannie LittleBeannie requested a review from nanxstats April 14, 2023 15:41
nanxstats
nanxstats approved these changes Apr 16, 2023
View reviewed changes
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I'm a bit worried about the growing cyclomatic complexity of fixed_design(), I'm going to approve this as it fixes the bug which produces wrong results.

@nanxstats nanxstats merged commit bb96730 into main Apr 16, 2023
@nanxstats nanxstats deleted the 207-gsdesign-vs-fixed_design-with-lf branch April 16, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanxstats nanxstats nanxstats approved these changes

Assignees

@LittleBeannie LittleBeannie

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gsDesign vs fixed_design with lf
2 participants
@LittleBeannie @nanxstats