-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move function to internal #261
Changes from 1 commit
26d9870
4f58c51
7024838
1198152
df9f441
c78be24
c282f32
d0798c6
2471a53
4736a69
61938bb
9903a13
af743f7
4330455
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -97,9 +97,6 @@ reference: | |
- expected_accrual | ||
- ppwe | ||
- s2pwe | ||
- gridpts | ||
- h1 | ||
- hupdate | ||
- gs_create_arm | ||
|
||
articles: | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little concerned that if it is okay to delete the examples of
gs_spending_bound
, considering it is an exported function,There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many refer people to the vignettes?
Or we should create examples without h1() function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we only show the 1st analysis bound, then we can get rid of
h1
. Otherwise, if we show the 2nd analysis bound, then we needh1
. I personally feel the 2nd analysis is necessary... for the presentation of a comprehensive story.I am open to referring people to vignettes in
@examples
, and will defer to @nanxstats for his suggestions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decision: change the examples in gs_spending_bound as we have in gs_design_ahr.