Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to roxygen2 7.3.0 #314

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

jdblischak
Copy link
Collaborator

Closes #313

It turns out that if I remove the quotes around := and %>%, then the NAMESPACE is correctly generated by both roxygen2 7.2.3 and 7.3.0

@jdblischak jdblischak self-assigned this Jan 16, 2024
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I'm often reluctant to suggest changes that would lead to large-scale changes (such as requiring 10+ PRs to update all packages), looks like we may need a path forward here before the next roxygen2 release, and this might be the only way.

I hope roxygen2 > 7.3.0 will fix the bug to support with quotes and keep supporting without quotes so we don't need to change this back. 🤞

@nanxstats nanxstats merged commit f4a9e8d into Merck:main Jan 16, 2024
8 checks passed
@jdblischak
Copy link
Collaborator Author

requiring 10+ PRs to update all packages

I view this as a temporary problem. Thus we only need to update packages that are being actively developed

I hope roxygen2 > 7.3.0 will fix the bug to support with quotes and keep supporting without quotes so we don't need to change this back.

That's why I tested with roxygen2 7.2.3. The unquoted version worked before, currently works, and will continue to work. And I'm less worried about future problems since the PR r-lib/roxygen2#1574 is adding tests for all the various use cases (no quotes, single quotes, double quotes, and back ticks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roxygen2 7.3.0 breaks NAMESPACE
2 participants