Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualify namespaces in tests to avoid library() calls #332

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

nanxstats
Copy link
Collaborator

Following the recommendation in R Packages (also tidyverse and tidymodels conventions), this PR removes the extra library() calls from tests/testthat.R and individual tests, and qualify the namespaces explicitly.

The involved namespaces and functions include (might not be exhaustive):

- gsDesign: gsDesign gsSurv gsBoundSummary sfLDOF
- tibble: tibble
- dplyr: filter mutate transmute full_join group_by summarize ungroup
  first last lag lead select arrange desc right_join rename

Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nanxstats !

@nanxstats nanxstats merged commit 6ca554a into main Feb 8, 2024
8 checks passed
@nanxstats nanxstats deleted the test-namespace branch February 8, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants