Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vignette for spending bounds under nph #336

Merged
merged 7 commits into from
Feb 14, 2024
Merged

Update vignette for spending bounds under nph #336

merged 7 commits into from
Feb 14, 2024

Conversation

LittleBeannie
Copy link
Collaborator

@LittleBeannie LittleBeannie commented Feb 13, 2024 •
edited by nanxstats
Loading

Closes #290

This PR:

  • Updated the vignette "trial design with spending under NPH".
  • Extended the vignette "computing spending boundaries in group sequential design" to compare derivation of different spending bounds using gsDesign2 and gsDesign.

@LittleBeannie LittleBeannie added the documentation Improvements or additions to documentation label Feb 13, 2024
nanxstats
nanxstats approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@nanxstats nanxstats left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the substantial improvement!

I excluded the linting rule for the vignette with camel case variable names, as it was intended for comparison and contrast purposes.

@nanxstats nanxstats merged commit dc48a64 into main Feb 14, 2024
8 checks passed
@nanxstats nanxstats deleted the Update-vignette-for-spending-bounds-under-NPH branch February 14, 2024 02:11
@LittleBeannie LittleBeannie mentioned this pull request Feb 14, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanxstats nanxstats nanxstats approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update spending bound vignette
3 participants
@LittleBeannie @nanxstats @keaven