Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name of gs_update_ahr() test file to follow convention #412

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

jdblischak
Copy link
Collaborator

Follow up to #378

I noticed that the test file for gs_update_ahr() was the only one that uses dashes instead of underscores in the filename.

$ ls tests/testthat/ -1 | grep -v '_'
fixtures/
helper.R
helper-developer-summary.R
helper-double-programming-ppwe.R
test-developer-ahr.R
test-developer-fastlag.R
test-developer-gridpts.R
test-developer-summary.R
test-independent-ahr.R
test-independent-gridpts.R
test-independent-gs-update-ahr.R
test-independent-h1.R
test-independent-hupdate.R
test-independent-rmst.R

@jdblischak jdblischak self-assigned this Jun 10, 2024
Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks, @jdblischak !

@LittleBeannie LittleBeannie merged commit 358cc87 into Merck:main Jun 11, 2024
7 checks passed
@jdblischak jdblischak deleted the update-test-file-name branch June 11, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants