Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

84 api #96

Merged
merged 73 commits into from
Nov 15, 2022
Merged

84 api #96

merged 73 commits into from
Nov 15, 2022

Conversation

LittleBeannie
Copy link
Collaborator

No description provided.

@LittleBeannie
Re-org inst
4eef854
@LittleBeannie
update API in AHR
18afc09
@LittleBeannie
update API in check_arg
5555a68
@LittleBeannie
update API in eEvents_df
6b15946
@LittleBeannie
update 2 check vignettes
b8a3c73
@LittleBeannie
update API of eAccrual
949e04e
@LittleBeannie
html is updated
4de469e
@LittleBeannie
update API in tEvents.R
e023f88
@LittleBeannie
2 minor update to vignettes
b9884ff
@LittleBeannie
update API for gs_design_ahr, gs_power_ahr and gs_info_ahr
e0d9063
@LittleBeannie
update IF -> info_frac in the output of gs_design_npe and `gs_power…
5ea2c3a 
…_npe`
@LittleBeannie
update API for gs_design_wlr, gs_power_wlr, gs_info_wlr and uti…
70f753e 
…lity_wlr`
@LittleBeannie
delete redundant vignettes
c7efa4c
@LittleBeannie
update API for gs_design_combo, gs_power_combo, gs_info_combo, …
4b5deff 
…`utility_combo`
@LittleBeannie
one left combo uncomitted
79d42de
@LittleBeannie
update API of rmst
f147bdf
@LittleBeannie
update API of fixed_design
8a1e86d
@LittleBeannie
update usage_ahr vignette
2694159
@LittleBeannie
update usage_eEvents vignette
8b049f3
@LittleBeannie
update API of gs_design_rd, gs_power_rd
b758924
@LittleBeannie
update the usage_fixed_design vignette
7354573
@LittleBeannie
delete a place holder vignette
df5ad5a
@LittleBeannie
minor update of a vignette
8b34f1b
@LittleBeannie
delete place holder vignettes
80188f1
@LittleBeannie
update usage_as_gt vignette
bc8100f
@LittleBeannie
update usage_tEvents vignette
2185e46
@LittleBeannie
update usage_gs_spending_bound vignette
7fe3a86
@LittleBeannie
update usage_gs_power_npe vignette
5488222
@LittleBeannie
update usage_gs_info_ahr
4a30c3f
@LittleBeannie
update story_ahr_under_nph vignette
1a98732
@nanxstats nanxstats merged commit 6cee3fa into main Nov 15, 2022
@nanxstats
Copy link
Collaborator

Congratulations finishing this "large-scale change". 👍

I wonder if the input argument order of certain functions such as expected_accrual() should be adjusted following the "data, descriptor, details" order. https://design.tidyverse.org/args-data-details.html but that can probably happen in a later PR.

@LittleBeannie
Copy link
Collaborator Author

Congratulations finishing this "large-scale change". 👍

I wonder if the input argument order of certain functions such as expected_accrual() should be adjusted following the "data, descriptor, details" order. https://design.tidyverse.org/args-data-details.html but that can probably happen in a later PR.

Good suggestion! Let's polish it in another PR.

@LittleBeannie LittleBeannie deleted the 84-api branch December 7, 2022 19:25
@LittleBeannie LittleBeannie self-assigned this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanxstats nanxstats nanxstats approved these changes

Assignees

@LittleBeannie LittleBeannie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API
2 participants
@LittleBeannie @nanxstats