Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change fixedBlockRand to randomize_by_fixed_block #62

Merged
merged 11 commits into from
Feb 23, 2023

Conversation

LittleBeannie
Copy link
Collaborator

No description provided.

@LittleBeannie LittleBeannie linked an issue Feb 7, 2023 that may be closed by this pull request
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of rand_by_fixed_block, let's use randomize_by_fixed_block.

@LittleBeannie
Copy link
Collaborator Author

randomize_by_fixed_block

Good suggestion! @lili-ling-msd, let's change the function name to randomize_by_fixed_block.

@LittleBeannie LittleBeannie changed the title change fixedBlockRand to rand_by_fixed_block change fixedBlockRand to randomize_by_fixed_block Feb 7, 2023
@LittleBeannie
Copy link
Collaborator Author

Hi @nanxstats, could you please approve this PR? Since I initially created this PR as a demo for Lili and Xintong, I am not allowed to approve it now. Thanks!

Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch - approved.

@nanxstats nanxstats merged commit 1cde2af into main Feb 23, 2023
@nanxstats nanxstats deleted the 32-fixedblockrand-rand_by_fixed_block branch February 23, 2023 22:12
@LittleBeannie LittleBeannie self-assigned this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixedBlockRand -> rand_by_fixed_block
3 participants