Fix swift optional newtype #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsumabat
force-pushed
the
joseph/swift-optional-newtype-fix
branch
from
1872596 to
8c1eb9d
Compare
josephsumabat
force-pushed
the
joseph/swift-optional-newtype-fix
branch
from
8c1eb9d to
60e07a1
Compare
kylebshr
reviewed
Nov 8, 2023
| @@ -1,4 +1,4 @@ | |||
| struct Newtype { | |||
| typealias NewtypeTag = Tagged<Newtype, Int?> | |||
There was a problem hiding this comment.
What is this test testing? Will a single Maybe still generate this question mark, because it should not
There was a problem hiding this comment.
It looks like it does the right thing in your other PR - should we add a test for that?
There was a problem hiding this comment.
This is the nested Maybe case
sebastienwindal
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate optional newtypes correctly, so the property itself is optional rather than the content of the
Taggedtype