Record-wrapping newtypes should produce MoatStruct #88
+21
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
Aeson serializes this as a JSON object like:
But Moat generates Kotlin code that deserializes this as its wrapped value, so we expect
"foo"
on the wire. The Mercury codebase has a ton ofnewtypeToStruct
calls to coerce these into MoatStruct, and backend engs don't really know about this nuance so it's forgotten.This changes
mkNewtype
to produce aMoatStruct
if the wrapped constructor is a record constructor. In addition, this lifts the restriction that newtypes can't wrap records with multiple fields.I am not sure if this breaks Swift codegen. If I'm correct about Aeson's output, then generating untagged structs shouldn't make a difference.