Use field label modifier on deprecated #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiroptical
approved these changes
Oct 16, 2024
| , omitFields = const Discard | ||
| , deprecatedFields = [("field1", Just "Deprecated since build 500")] | ||
| , deprecatedFields = [("testField1", Just "Deprecated since build 500")] |
There was a problem hiding this comment.
It isn't obvious, but do we require testField1 to exist?
There was a problem hiding this comment.
If required fields are included we check testField1 is one of the required fields if deprecated. We don't check that it isn't a part of omitFields though it might make sense to add that (I can do it as part of another PR)
tadfisher
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously not applying the field label modifier - fixes that issue.