Skip to content

Add type check when creating a new MerginProject #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025
Merged

Add type check when creating a new MerginProject #255

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18800da
Add type check when creating a new MerginProject
constantinneagu Jul 25, 2025
c18b3a1
Support pathlib.Path objects when initializing a MerginProject
constantinneagu Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mergin/merginproject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def _logger_callback(level, text_bytes):

def setup_logging(self, logger_name):
"""Setup logging into project directory's .mergin/client-log.txt file."""
self.log = logging.getLogger("mergin.project." + logger_name)
self.log = logging.getLogger("mergin.project." + str(logger_name))
self.log.setLevel(logging.DEBUG) # log everything (it would otherwise log just warnings+errors)
if not self.log.handlers:
# we only need to set the handler once
Expand Down