Skip to content

Add auth logging #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2025
Merged

Add auth logging #269

merged 2 commits into from
Sep 10, 2025

Conversation

@harminius
Copy link
Contributor

@harminius harminius commented Sep 9, 2025

A step to understand MerginMaps/qgis-plugin#804

Remove duplicate logging

Add meaningful logging.

@harminius harminius requested a review from MarcelGeo September 9, 2025 09:32
@coveralls
Copy link

coveralls commented Sep 10, 2025

Pull Request Test Coverage Report for Build 17612791349

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 128 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.3%) to 80.216%
Files with Coverage Reduction New Missed Lines %
mergin/test/sqlite_con.py 10 0.0%
mergin/client_push.py 11 77.11%
mergin/test/test_client.py 35 97.96%
mergin/client.py 72 87.37%
Totals Coverage Status
Change from base Build 17458681863: -0.3%
Covered Lines: 3495
Relevant Lines: 4357
💛 - Coveralls

@MarcelGeo MarcelGeo merged commit fe833f1 into master Sep 10, 2025
4 checks passed
@MarcelGeo MarcelGeo deleted the auth_logging branch September 10, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcelGeo MarcelGeo MarcelGeo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harminius @coveralls @MarcelGeo