add photo quality setting to mergin project properties #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterPetrik
approved these changes
Apr 21, 2022
|
May I suggest that this new option will also get a dedicated group box, and a short explanatory label, e.g.: "This option is used by Input when adding pictures to the project (taken from camera or using existing picture from gallery)." |
wonder-sk
reviewed
Apr 21, 2022
|
It wooudl be good to add expanatory text as Martin suggested |
|
Explanatory text added. Also added link to the selective sync documentation.
|
|
I suggest rewording the text for selective sync to "With selective sync enabled Input will not download photos from other surveyors to make synchronisation faster. Check out more in the documentation" Otherwise, I believe we are ready to merge (afaik it passed testing by @jozef-budac ). @wonder-sk |
|
Good suggestion @tomasMizera - let's update the text :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dropdown to Mergin project settings dialog with the following options: "Original", "High", "Medium" and "Low". By default "Original" setting is used to keep backward compatibility.
Refs MerginMaps/mobile/issues/841.