Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v2 update project access #349

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Conversation

MarcelGeo
Copy link
Contributor

@MarcelGeo MarcelGeo commented Dec 18, 2024

Resolves https://github.com/MerginMaps/server-private/issues/2672
Partially resolves https://github.com/MerginMaps/server-private/issues/2686

Cleanup 💥

  • 'none' ProjectRole , not sure if there is use case for it (in PUT v1/access ? @varmar05
  • started cleanup of asAdmin attributes

Added ➕

  • Added project_role attribute to private endpoint for /access as we can use it for checking if there is any
  • added error handling methods for some endpoints used to limits with pinia plugin

Updated 🔨

  • rename and introduce ProjectCollaborators methods handling in api and project store

@coveralls
Copy link

coveralls commented Dec 18, 2024

Pull Request Test Coverage Report for Build 12412949550

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 93.528%

Totals Coverage Status
Change from base Build 12374107552: 0.003%
Covered Lines: 6662
Relevant Lines: 7123

💛 - Coveralls

@MarcelGeo MarcelGeo merged commit e84681e into develop Dec 20, 2024
4 checks passed
@MarcelGeo MarcelGeo deleted the use-v2-update-project-access branch January 1, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants