-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user property declarations support #85
Merged
MerlinVR
merged 14 commits into
MerlinVR:master
from
mika-f:natsuneko/support-user-defined-properties
Jun 14, 2021
Merged
Add user property declarations support #85
MerlinVR
merged 14 commits into
MerlinVR:master
from
mika-f:natsuneko/support-user-defined-properties
Jun 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as not been exported
…sing [field: UdonSynced]
- Fix case where property return values are shared which can cause issues with stuff like `MyValue + MyValue` where the getter for `MyValue` modifies the return
- Fix redundant gets on prefix/postfix decrement and increment causing them to misbehave on properties
…izer - Attempting to serialize anonymous backing fields breaks the serializer, so don't.
- Make setter and getter methods start with an underscore since they cannot be called via the network.
This looks good, thank you! I fixed some edge cases that were mostly due to other systems not handling properties correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following property declarations will now be compiled by UdonSharp.
In this pull request, the compiler internally converts to UdonAssembly as method declarations and method calls, just like in real C#.
For example,
public string SomeProperty { get; private set; }
will be converted into UdonAssembly as shown below:Also, property calls (like
_instance.SomeProperty
) are converted as follows:The concern is that it is currently a low priority and may reduce the maintainability of the compiler; also, many users can build UdonSharp code without this feature without any problems.