This repository was archived by the owner on Jun 15, 2024. It is now read-only.
Bump the Android native library in order to fix a crash with certain PDFs #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh when loading a PDF like https://loopmein-dev.imgix.net/vehicle-documents/d21fcae0-85be-4577-8ee5-d5452c9c1255.pdf (not sure why that crashed though). Also: a little cleanup, and switched to the now-mandatory 'implementation' (instead of 'compile').
|
Hey there @EddyVerbruggen - thanks for your PR, and sorry I haven't been quite attentive to this package, with lots of other commitments these days. Merging now. |
Merott
pushed a commit
that referenced
this pull request
Mar 14, 2019
|
Hey @Merott, that's how things go sometimes, I know all about it. Thanks for merging this so quickly, really looking forward to adding this fix to my projects. Good luck with all your commitments! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Long time fan (and user) of your plugin!
Today we found this particular PDF crashes the app when loaded: https://loopmein-dev.imgix.net/vehicle-documents/d21fcae0-85be-4577-8ee5-d5452c9c1255.pdf
The reason is unknown, the only thing we know is it's fixed by bumping the native Android library to the latest version of the 2.x branch. Somewhere in between 2.5.1 and 2.8.2 this crash was fixed by the author.
While I was in the gradle file I also switched
compiletoimplementation, since that's the recommended way to load libraries in gradle these days.Also added
.vscodeto.npmignorebecause it has no business in the npm package.Thanks a lot for considering merging this, and it would be awesome if you can publish a new version to npm as well!