Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bip32 #506

Merged
merged 38 commits into from
Feb 17, 2025
Merged

Refactor bip32 #506

merged 38 commits into from
Feb 17, 2025

Conversation

twwu123
Copy link
Collaborator

@twwu123 twwu123 commented Feb 14, 2025

Summary

Removing Strica packages for key derivation, and replacing everything with harmoniclabs/cbor for cbor specific operations and cardano-js-sdk for key serialization.

Unfortunately, the cardano-js-sdk library required a single call to await Crypto.init() before any key derivations can happen, which means wallet implementations will need to call await Wallet.init() before any operations - this will call await Crypto.init().

Affect components

Please indicate which part of the Mesh Repo

  • @meshsdk/common
  • @meshsdk/contract
  • @meshsdk/core
  • @meshsdk/core-csl
  • @meshsdk/core-cst
  • @meshsdk/provider
  • @meshsdk/react
  • @meshsdk/svelte
  • @meshsdk/transaction
  • @meshsdk/wallet
  • Mesh playground (i.e. https://meshjs.dev/)
  • Mesh CLI

Type of Change

Please mark the relevant option(s) for your pull request:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Code refactoring (improving code quality without changing its behavior)
  • Documentation update (adding or updating documentation related to the project)

Checklist

Please ensure that your pull request meets the following criteria:

  • My code is appropriately commented and includes relevant documentation, if necessary
  • I have added tests to cover my changes, if necessary
  • I have updated the documentation, if necessary
  • All new and existing tests pass (i.e. npm run test)
  • The build is pass (i.e. npm run build)

Additional Information

BREAKING - some wallet functions are now async, and will require a wallet.init() call before anything can be used.

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mesh-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 11:21am
mesh-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 11:21am

@jinglescode jinglescode marked this pull request as ready for review February 17, 2025 11:15
@jinglescode jinglescode merged commit fbbde0f into main Feb 17, 2025
4 checks passed
@jinglescode jinglescode deleted the refactor-bip32 branch February 17, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants