Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting of default ImmutableArray<T> values #1037

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Fix formatting of default ImmutableArray<T> values #1037

merged 1 commit into from
Sep 14, 2020

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Sep 12, 2020

Also add some perf improvements to the formatter for empty arrays.

Fixes #1033

@AArnott
Fix formatting of default ImmutableArray<T> values
71f78d5 
Also add some perf improvements to the formatter for empty arrays.

Fixes MessagePack-CSharp#1033
@AArnott AArnott added this to the v2.1 milestone Sep 12, 2020
@AArnott AArnott requested a review from neuecc September 12, 2020 13:46
@AArnott AArnott self-assigned this Sep 12, 2020
@AArnott
Copy link
Collaborator Author

AArnott commented Sep 12, 2020

CC: @tmat

tmat
tmat approved these changes Sep 13, 2020
View reviewed changes
Copy link

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

neuecc
neuecc approved these changes Sep 13, 2020
View reviewed changes
Copy link
Member

@neuecc neuecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@AArnott AArnott merged commit 4a93481 into MessagePack-CSharp:master Sep 14, 2020
@AArnott AArnott deleted the fix1033 branch September 14, 2020 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuecc neuecc neuecc approved these changes

@tmat tmat tmat approved these changes

Assignees

@AArnott AArnott

Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

default(ImmutableArray<T>) is not serialized correctly
3 participants
@AArnott @tmat @neuecc