Cddso 414 cp4a mappings tweaks#245
Merged
matthew-mizielinski merged 13 commits intov2.5_releasefrom Apr 12, 2024
Merged
Conversation
…nstantaneous) mappings. Removed 1-hour mappings for [rsdt, rsut] as these do not exist in u-cx157. Removed SfcWind as this does not exist in u-cx157.
…mon mappings, changed 3hr to GC3hr for mrros
…or prw, clwvi, clivi
… not overwritten for daily/monthly variables on pressure levels.
…y frequencies in HadREM-CP4A model
mo-kerstinschmatzer
requested changes
Apr 11, 2024
Collaborator
mo-kerstinschmatzer
left a comment
mo-kerstinschmatzer
left a comment
There was a problem hiding this comment.
Code lgtm, but unit tests are failing
…lt section and indentation fix on test file
Collaborator
Author
|
Doh! focussed on fixing one set of tests and failed to run the full test suite 🤦 Tests now fixed and all pass. Note that I've made a minor tweak to the GC3hrPt mappings file introduced in this issue as a minor tidy up (moving common entry to default section) |
matthew-mizielinski
added a commit
that referenced
this pull request
Apr 12, 2024
Cherry pick from v2.5_release, with minor changes following refactoring in CDDSO-387 CDDSO-414: Changes to support use of HadREM3-CP4a model: * Increased memory limits * reduced chunk sizes for all sub-daily frequencies * Added mappings * Extended sequence used for the hierarchy of mappings files and updated associated testsl --------- Co-authored-by: JoshMacholl <joshua.macholl@metoffice.gov.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweaks to memory and sizing information for the HadREM-CP4a model
Clarification of the priority order of the mappings files:
common_mappings.cfg(lowest)<mip_table>_mappings.cfg<model_family>_mappings.cfg<model_family>_<mip_table>_mappings.cfg<model>_mappings.cfg<model>_<mip_table>_mappings.cfg(highest)I've updated the tests to include the full order, but to filter out non-existent files from this list.