-
Notifications
You must be signed in to change notification settings - Fork 1
Add "metric", "recipe", and "assessment area" to the glossary #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add "metric", "recipe", and "assessment area" to the glossary #329
Conversation
|
|
||
| .. glossary:: | ||
|
|
||
| Assessment Area |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace in line -1: 2022-2025 with 2022-2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 390f649.
mo-nikosbaltas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the '.. (C) Crown Copyright 2022-2025, Met Office.' to 2022-2026 for all the other .rst files?
|
Sorry, not all the .rst files only the ones you had changed. |
|
Can you add the appropriate milestone to the PR |
|
Thanks for catching the copyright statements. All corrected and ready for re-review. |
mo-nikosbaltas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. Approved.
ehogan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jon-Lillis 🥳
Would it be possible for you to add pipes around all instances of metric, recipe and assessment area in the documentation, including in the glossary, please? 😊
ehogan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also:
- Ensure the text of the PR title exactly matches with the text (not including the issue number) of the issue title
Added in 2718624. |
Quotes added to the title. |
Would it be possible to also do this for |
There's also an extra command after "recipe" 🤪 |
Closes #84.
PR creation checklist for the developer
<issue_number>above ☝️ been replaced with the issue number?mainbeen selected as the base branch?<issue_number>_<short_description_of_feature>?good first issuelabel) been added to the PR?Climate Model Evaluation Workflow (CMEW)project been added to the PR?Definition of Done for the developer
docdirectory) related to the change been updated appropriately, including the Quick Start section?PR creation checklist for the reviewer
<issue_number>above ☝️ been replaced with the issue number?mainbeen selected as the base branch?<issue_number>_<short_description_of_feature>?good first issuelabel) been added to the PR?Climate Model Evaluation Workflow (CMEW)project been added to the PR?Definition of Done for the reviewer
docdirectory) related to the change been updated appropriately, including the Quick Start section?