Skip to content

Conversation

@james-bruten-mo
Copy link
Contributor

@james-bruten-mo james-bruten-mo commented Oct 21, 2025

Adds files required for rose stem extraction from github, either syncing a local clone, or cloning from github or from a github mirror.

This also rearranges some of the file structure in this repo, creating a new github_scripts repo in which the new files, suite_report_git and git_bdiff now live. The files were moved in the first commit - any subsequent changes to existing files are in later commits (actually it looks like github displays those changes nicely anyway).
The changes to suite_data make a modification to finding the clone source now that Cylc8.6 is available. I had expected this variable to be available in the cylc database, but it isn't exposed there, so instead it's reading a log message from the suite.
It also changes to use the clone and sync functions from the new get_git_sources file to reduce duplication a bit.

Copy link
Contributor

@t00sa t00sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I've suggested a couple of tweaks but it's up to you whether you think they're an improvement or not...

james-bruten-mo and others added 2 commits October 21, 2025 14:30
Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
@james-bruten-mo james-bruten-mo requested a review from t00sa October 21, 2025 13:36
@james-bruten-mo
Copy link
Contributor Author

Sorry, going to need a change to these files to allow access via tokens to support running on Monsoon. I'll put this back to in progress until that's done

@cameronbateman-mo cameronbateman-mo marked this pull request as draft October 22, 2025 09:40
@james-bruten-mo james-bruten-mo marked this pull request as ready for review October 22, 2025 12:47
@james-bruten-mo
Copy link
Contributor Author

Changes to allow running with https and tokens now added. Ready for review again @t00sa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants