BUG: fixed missing file handling for remote polling #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpelley
force-pushed
the
fixed_datapolling
branch
from
538ad7b
to
6bcb43d
Compare
cpelley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote polling wasn't correctly handling case of missing files when the path didn't contain Unix shell-style wildcards (which we specifically handled using an inverted grep call).
Now we echo on condition of the file existing and added a new test for this case. The pre-existing unittest for missing file handling was for a local filepath i.e. python glob. This new test ensures handling via remote (ssh) glob.
Issues