Merged
Conversation
james-bruten-mo
requested review from
andrewcoughtrie
and removed request for
a team
andrewcoughtrie
approved these changes
Dec 1, 2025
Collaborator
andrewcoughtrie
left a comment
andrewcoughtrie
left a comment
There was a problem hiding this comment.
Just giving this a passing review status because for some reason the build docs action isn't running, it's fine on Apps and the settings all look the same so I'm trying to work out what's going on here.
jennyhickson
reviewed
Dec 1, 2025
Collaborator
jennyhickson
left a comment
jennyhickson
left a comment
There was a problem hiding this comment.
and a couple of questions here?
| cp $SOURCE_ROOT/SimSys_Scripts/github_scripts/suite_report_git.py $CYLC_WORKFLOW_RUN_DIR/bin | ||
| cp $SOURCE_ROOT/SimSys_Scripts/github_scripts/suite_data.py $CYLC_WORKFLOW_RUN_DIR/bin | ||
| cp $SOURCE_ROOT/SimSys_Scripts/github_scripts/git_bdiff.py $CYLC_WORKFLOW_RUN_DIR/bin | ||
| cp $SOURCE_DIRECTORY/SimSys_Scripts/github_scripts/get_git_sources.py $CYLC_WORKFLOW_RUN_DIR/bin |
Collaborator
There was a problem hiding this comment.
why SOURCE_DIRECTORY not SOURCE_ROOT for this final one?
Collaborator
Author
There was a problem hiding this comment.
I don't know why I did it like that! Changed for consistency
rose-stem/rose-suite.conf
Outdated
| HOUSEKEEPING=true | ||
| LDFLAGS='' | ||
| OVERRIDE_LOG_LEVEL='' | ||
| SIMSYS_BRANCH='main' |
Collaborator
There was a problem hiding this comment.
does this still need specifying here if its now in the dependencies file?
Collaborator
Author
There was a problem hiding this comment.
No, I missed that - deleted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes required to run the lfric_core test suite after the git migration. This PR is being opened in draft mode, to give visibility of the upcoming changes. The PR will be completed for the migration to github.