Skip to content

add github files#168

Merged
andrewcoughtrie merged 8 commits intoMetOffice:mainfrom
james-bruten-mo:github_files
Dec 4, 2025
Merged

add github files#168
andrewcoughtrie merged 8 commits intoMetOffice:mainfrom
james-bruten-mo:github_files

Conversation

@james-bruten-mo
Copy link
Collaborator

@james-bruten-mo james-bruten-mo commented Dec 3, 2025

Update the lfric_core pr template, .gitignore and Readme files. Also add the check-cr-approved workflow to check that the assigned code reviewer has approved the PR.

Question for Steve and Andy is whether the original licence file should remain in place?

@stevemullerworth
Copy link
Collaborator

Question for Steve and Andy is whether the original licence file should remain in place?

I think it would be fine to remove the original licence as there is no difference between the two licences. We have two only because we didn't think enough about the separation between the licence and the copyright (there are two alternative copyright statements in lfric_core).

However, the references in the older files that contain the alternative "Queens Printer" copyright would need to change to point to LICENCE instead of LICENCE.original.

@james-bruten-mo
Copy link
Collaborator Author

Thanks Steve, I've done that. It's made this ticket quite a bit bigger, so if you'd prefer I revert that then no problem

Comment on lines 18 to 19
- closes #issue-number
- fixes #issue-number
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a little bit of comment to say that these will auto close the issue as not all of these examples will.

james-bruten-mo and others added 2 commits December 4, 2025 16:21
Co-authored-by: Andrew Coughtrie <24609575+andrewcoughtrie@users.noreply.github.com>
Copy link
Collaborator

@andrewcoughtrie andrewcoughtrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me now.

@andrewcoughtrie andrewcoughtrie merged commit 269f49d into MetOffice:main Dec 4, 2025
2 of 3 checks passed
@andrewcoughtrie andrewcoughtrie deleted the github_files branch December 4, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments