Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify GA and local doc build #247

Merged
merged 2 commits into from
Sep 16, 2024
Merged

unify GA and local doc build #247

merged 2 commits into from
Sep 16, 2024

Conversation

yaswant
Copy link
Contributor

@yaswant yaswant commented Sep 13, 2024 •
edited
Loading

It appears that we have sphinx dependencies included in multiple places: GitHub Action workflow for doc build for gh-pages and env.yml for local build. In this PR I've put all dependencies in one place .github/workflows/requirements.txt and amended a malformed rst table.

jennyhickson
jennyhickson approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@jennyhickson jennyhickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying this - its bugged me for a while that there were duplicate definitions but hadn't had the time to work out how to pass the same thing to both.

@yaswant yaswant self-assigned this Sep 16, 2024
@yaswant yaswant added the 🪄Enhancement New feature or request label Sep 16, 2024
@yaswant yaswant merged commit ba83e6a into MetOffice:main Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyhickson jennyhickson jennyhickson approved these changes

@r-sharp r-sharp Awaiting requested review from r-sharp

@t00sa t00sa Awaiting requested review from t00sa

Assignees

@yaswant yaswant

Labels
🪄Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaswant @jennyhickson