Move AM renamer to gather. Allows us to properly use sundew variable expansions. #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should've probably been tested before v3.00.52rc2 but oh well.
I started toying around with Sundew compatible substitutions and ran into some problems.
The renamer was getting called via
after_acceptwhich is wrong since we're doing Sundew substitutions BEFORE callingafter_accept. With this PR, by moving the renamer before the filtering, we essentially avoid all of the limbo that is required to call the sundew substitutions after the filtering. It makes the whole process easier and makes more sens.