Skip to content

Commit

Permalink
Fix e2e tests run
Browse files Browse the repository at this point in the history
  • Loading branch information
filippomc committed Jan 16, 2025
1 parent 77852b7 commit 80c7236
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 0 deletions.
14 changes: 14 additions & 0 deletions ch-166.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
diff --git a/tools/deployment-cli-tools/ch_cli_tools/codefresh.py b/tools/deployment-cli-tools/ch_cli_tools/codefresh.py
index 8bcf2b79..3ea43e31 100644
--- a/tools/deployment-cli-tools/ch_cli_tools/codefresh.py
+++ b/tools/deployment-cli-tools/ch_cli_tools/codefresh.py
@@ -175,8 +175,7 @@ def create_codefresh_deployment_scripts(root_paths, envs=(), include=(), exclude

if app_config and app_config.dependencies and app_config.dependencies.git:
for dep in app_config.dependencies.git:
- step_name = f"clone_{basename(dep.url).replace('.', '_')}_{basename(dockerfile_relative_to_root).replace('.', '_')}"
- steps[CD_BUILD_STEP_DEPENDENCIES]['steps'][step_name] = clone_step_spec(dep, dockerfile_relative_to_root)
+ steps[CD_BUILD_STEP_DEPENDENCIES]['steps'][f"clone_{basename(dep.url).replace(".", "_")}_{basename(dockerfile_relative_to_root).replace(".", "_")}"] = clone_step_spec(dep, dockerfile_relative_to_root)

build = None
if build_step in steps:
1 change: 1 addition & 0 deletions deployment-configuration/codefresh-template-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ steps:
image: "${{test-e2e}}"
fail_fast: false
commands:
- npx puppeteer browsers install chrome
- yarn test
scale: {}
hooks:
Expand Down
1 change: 1 addition & 0 deletions deployment/codefresh-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,7 @@ steps:
image: '${{REGISTRY}}/cloudharness/test-e2e:${{TEST_E2E_TAG}}'
fail_fast: false
commands:
- npx puppeteer browsers install chrome
- yarn test
scale:
jupyterhub_e2e_test:
Expand Down

0 comments on commit 80c7236

Please sign in to comment.