Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release back to develop #467

Merged
merged 17 commits into from
May 4, 2022
Merged

Release back to develop #467

merged 17 commits into from
May 4, 2022

Conversation

filippomc
Copy link
Collaborator

@filippomc filippomc commented Mar 18, 2022

Closes #466

Implemented solution: changed configuration on Argo chart to singleNamespace

How to test this PR: run a workspace from the argo ui or cli

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are in the Review/QA column of the board
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@filippomc filippomc added bug Something isn't working chore labels Mar 18, 2022
@filippomc filippomc requested a review from zsinnema March 18, 2022 16:12
@filippomc filippomc changed the title #466 chore lock argo to the current namespace Release back to develop May 4, 2022
@zsinnema zsinnema merged commit 686b428 into develop May 4, 2022
@filippomc filippomc deleted the release/1.0.0 branch May 4, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argo installations are mixing up
2 participants