Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#635 feat: add user defined exception for use for general pod spawn errors #636

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

zsinnema
Copy link
Contributor

Closes #635

Implemented solution: added a "generic" Pod Spawn Exception to CH jupyterhub.py that is catched and raised again instead of the generic catch all log and continue exception

How to test this PR:

  • import PodSpawnException from harness_jupyter jupyterhub
  • raise this exception

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are in the Review/QA column of the board
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@zsinnema zsinnema added the enhancement New feature or request label Nov 24, 2022
@zsinnema zsinnema self-assigned this Nov 24, 2022
Copy link
Collaborator

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@filippomc filippomc merged commit 5802d03 into develop Nov 24, 2022
@filippomc filippomc deleted the feature/635 branch November 24, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudharness Jupyter add user defined exception PodSpawnException for raising Jupyter exception outside CH
2 participants