Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#637 feat: implement harness quota #641

Merged
merged 10 commits into from
Nov 29, 2022
Merged

#637 feat: implement harness quota #641

merged 10 commits into from
Nov 29, 2022

Conversation

zsinnema
Copy link
Contributor

@zsinnema zsinnema commented Nov 28, 2022

Closes #637

Implemented solution: ...

How to test this PR:
read the documentation of the _compute_quotas_from_tree function for setting up an example in Keycloak

from cloudharness.applications import get_configuration
from cloudharness.auth.quota import get_user_quotas

app_config = get_configuration("<the app with quotas>")
user_id = "<the user id to get the quota for>"
print(get_user_quotas(app_config, user_id))

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are in the Review/QA column of the board
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@zsinnema zsinnema added the enhancement New feature or request label Nov 28, 2022
@zsinnema zsinnema self-assigned this Nov 28, 2022
@filippomc filippomc merged commit 01b8f7f into develop Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic user quotas
2 participants