Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/638 #642

Merged
merged 14 commits into from
Nov 29, 2022
Merged

Feature/638 #642

merged 14 commits into from
Nov 29, 2022

Conversation

zsinnema
Copy link
Contributor

Closes #638

Implemented solution: use #637 for setting JH user quotas

How to test this PR: assign some user quotas, start Jupyterhub pod and check the assigned quotas

kubectl -n <namespace> get pvc  # check the user pvc size
kubectl -n <namespace> describe pod <pod name>  # check the cpu/mem request and limit

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are in the Review/QA column of the board
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@zsinnema zsinnema self-assigned this Nov 28, 2022
@zsinnema zsinnema added the enhancement New feature or request label Nov 28, 2022
@filippomc filippomc merged commit 0819f3c into develop Nov 29, 2022
@filippomc filippomc deleted the feature/638 branch November 29, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic Jupyterhub user quotas
2 participants