Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/652 #653

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Feature/652 #653

merged 2 commits into from
Dec 12, 2022

Conversation

zsinnema
Copy link
Contributor

Closes #652

Implemented solution: change the htlm tls certificate and the nginx template

How to test this PR: install a release on a v1.24 k8s cluster

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are in the Review/QA column of the board
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@zsinnema zsinnema added enhancement New feature or request alert:deployment Something may break in the scope of this issue/pr in existing deployments labels Dec 12, 2022
@zsinnema zsinnema self-assigned this Dec 12, 2022
@zsinnema zsinnema requested a review from filippomc December 12, 2022 15:48
Copy link
Collaborator

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filippomc filippomc merged commit d523ac0 into develop Dec 12, 2022
@filippomc filippomc deleted the feature/652 branch December 12, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert:deployment Something may break in the scope of this issue/pr in existing deployments enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix some Ingress issues: Issuer instead of ClusterIssuer, use Ingress class instead of name
2 participants