Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version #727

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Update node version #727

merged 2 commits into from
Jul 5, 2024

Conversation

filippomc
Copy link
Collaborator

@filippomc filippomc commented Feb 13, 2024

Closes CH-118

Implemented solution: The version has been updated in the CLOUDHARNESS_FRONTEND_BUILD image, which should be used a a dependency to build other node applications.

How to test this PR: Automated tests are enough here as the some images won't build if the image is not found

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are in the Review state
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@filippomc filippomc requested a review from zsinnema February 13, 2024 17:41
@filippomc filippomc merged commit 354424b into develop Jul 5, 2024
6 of 7 checks passed
@filippomc filippomc deleted the feature/CH-118 branch July 5, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant