Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/dashboard is broken in develop #1037

Closed
dysbulic opened this issue Jan 11, 2022 · 1 comment · Fixed by #943
Closed

/dashboard is broken in develop #1037

dysbulic opened this issue Jan 11, 2022 · 1 comment · Fixed by #943
Labels
bug Something isn't working frontend Front end related issues / features

Comments

@dysbulic
Copy link
Member

dysbulic commented Jan 11, 2022

What happened?

If you load, test.metagame.wtf/dashboard currently, it dies with a 500 server error.

What did you expect to happen?

The page to load correctly.

How can we reproduce the problem (as minimally as possible)?

Visit test.metagame.wtf/dashboard.

Is there anything else we need to know?

I did some tracing on the root error, Unable to find node on an unmounted component., locally, and it seems to be the ReactDOM.findDOMNode of:

this.cqCore.observe(ReactDOM.findDOMNode(this))

in react-container-query. This may be related to the recent upgrade to React 17.

I did a CodePen testing the ContainerQuery component with React 17, and it works, so there's no immediate issue there.

Downgrading to React 16.14.0 resolves the issue, so it is something to do with that upgrade. I notice that design-system is still using v16 of react-dom, which reportedly can cause this error. I'll put everything back to v17 & report back…

Browser and operating system used (if applicable)

All of them.

@dysbulic dysbulic added bug Something isn't working frontend Front end related issues / features labels Jan 11, 2022
@dysbulic dysbulic linked a pull request Jan 11, 2022 that will close this issue
@dysbulic
Copy link
Member Author

The issue was react-dom was still v16 in design-system. This is fixed in #943.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Front end related issues / features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant