Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading and Writing Profile Info From Ceramic #943

Merged
merged 131 commits into from
Jan 25, 2022
Merged

Reading and Writing Profile Info From Ceramic #943

merged 131 commits into from
Jan 25, 2022

Conversation

dysbulic
Copy link
Member

@dysbulic dysbulic commented Dec 1, 2021 •
edited
Loading

Overview

What features/fixes does this PR include?

This pull request does these primary things:

  1. It changes the process for loading data into Hasura from Ceramic from IDX to Glaze (Migrate existing IDX-based profile lookup to Glaze #917)
  2. It migrates the proxy for web3.storage from the Express backend to a Next.js API endpoint ([MyMeta] Migrate the web3.storage proxy from Express to Next.js #848)
  3. It enables saving of profile data into a split between Ceramic's basicProfile and an extended profile document (Save profile information to the Ceramic network #920)
  4. It changes the profile return values from Hasura from underscored to camel case so they can be destructured with regular React variables
  5. It updates the version of Node used for the front and backends to v16
  6. It fixes the Google Cloud Run deployments to update when changes are made to a pull request
  7. It refactors the rate limiting of requests to the Ceramic daemon (imperfectly Ceramic request rate limiting failover doesn't work #1061)

Follow up Improvement Ideas

  • React is upgraded to 17.0.2 for compatibility with react-form-hook.
  • Time zone is uniformly capitalized as timeZone since it is two words.
  • The typing on the profile editing page is nearly elegant. I am using a union type to check which fields go to which stream and to handle the mapping between Hasura ids and Ceramic ones.

Implementation

Describe technical (nontrivial / non-obvious) parts of your code

The main thing this PR does is it moves all the profile fields into their own table and defines the appropriate types for accessing them.

Side effects

The biggest side effects are from the fact that I standardized all the variable names as camel case when migrating them. The most pernicious was timeZone, which despite being two words was a mishmash of capitalizations.

@dysbulic dysbulic added backend Backend related issues frontend Front end related issues / features Hasura GraphQL / Hasura related tasks refactor Issues for opportunities to refactor parts of the codebase labels Dec 1, 2021
@dysbulic dysbulic self-assigned this Dec 1, 2021
@vercel
Copy link

vercel bot commented Dec 1, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/metafam/the-game/EhannHLwrRuMEv938kZQ4bjnNYSG
✅ Preview: Failed

[Deployment for ed53f5e failed]

@dysbulic dysbulic mentioned this pull request Dec 1, 2021
Merged
@dysbulic dysbulic marked this pull request as ready for review December 1, 2021 15:23
@dysbulic
Copy link
Member Author

dysbulic commented Dec 1, 2021

Reopening to try & trigger the Google test instances.

@dysbulic dysbulic closed this Dec 1, 2021
@dysbulic
Copy link
Member Author

dysbulic commented Dec 1, 2021

¿Does this work?

@dysbulic dysbulic reopened this Dec 1, 2021
@dysbulic
Copy link
Member Author

dysbulic commented Dec 1, 2021

Another reopen since the Google checks are running now that I've rebased it.

@dysbulic dysbulic closed this Dec 1, 2021
@dysbulic
Copy link
Member Author

dysbulic commented Dec 1, 2021

& open…

@dysbulic dysbulic reopened this Dec 1, 2021
@dysbulic dysbulic added the WIP label Dec 1, 2021
@dysbulic
Copy link
Member Author

dysbulic commented Dec 1, 2021

Reopening again for that Googlely goodness…

@dysbulic dysbulic closed this Dec 1, 2021
@dysbulic
Copy link
Member Author

dysbulic commented Dec 1, 2021

¡Et, voila!

@dysbulic dysbulic reopened this Dec 1, 2021
@dysbulic
Copy link
Member Author

dysbulic commented Dec 1, 2021

Kick down with the database manually removed.

@dysbulic dysbulic closed this Dec 1, 2021
@dysbulic
Copy link
Member Author

dysbulic commented Dec 1, 2021

Kick up. 😸

@dysbulic dysbulic reopened this Dec 1, 2021
@github-actions
Copy link

Successfully deployed a preview of this pull request:

@dysbulic dysbulic mentioned this pull request Jan 25, 2022
Closed
@github-actions
Copy link

Successfully deployed a preview of this pull request:

@dysbulic dysbulic merged commit f5295c3 into develop Jan 25, 2022
@dysbulic dysbulic deleted the feat/glaze-lookup branch January 25, 2022 21:51
@github-actions
Copy link

Successfully undeployed the Preview of this Pull Request

This was referenced Jan 26, 2022
Closed
Merged
Closed
Closed
Closed
tenfinney pushed a commit that referenced this pull request Mar 1, 2022
@dysbulic @tenfinney
Reading and Writing Profile Info From Ceramic (#943)
5a5d6e2 
This is being merged for further testing so as to not block the progress of `develop` & not require more rebases.
alalonde pushed a commit that referenced this pull request Mar 12, 2022
@dysbulic @alalonde
Reading and Writing Profile Info From Ceramic (#943)
809d373 
This is being merged for further testing so as to not block the progress of `develop` & not require more rebases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dysbulic dysbulic

Labels
backend Backend related issues frontend Front end related issues / features Hasura GraphQL / Hasura related tasks ready-for-review Add this label to your PR when its ready for review refactor Issues for opportunities to refactor parts of the codebase
Projects
MyMeta
Status: Done
Milestone
No milestone
4 participants
@dysbulic @vidvidvid @onefinney @tenfinney