Skip to content
This repository has been archived by the owner on May 12, 2022. It is now read-only.

Advanced Settings: Dev-specific UI Controls + Functionality #2

Closed
cjeria opened this issue Feb 28, 2018 · 6 comments
Closed

Advanced Settings: Dev-specific UI Controls + Functionality #2

cjeria opened this issue Feb 28, 2018 · 6 comments

Comments

@cjeria
Copy link
Contributor

cjeria commented Feb 28, 2018

We're starting to see a clearer dividing line between basic and advanced(dev-specific) features. The easiest place to put on/off switches for dev-specific functionality and ui control customizations is probably inside of settings.

Advanced features would include:

  • Network switcher
  • TX data field
  • nonce controls
  • Advanced Gas controls
  • Reset Account (which only affects TX history??)
  • Auto approve my transactions within an X window of time. (to reduce the amount of tx over and over)

Wireframe:
image

@danfinlay @Zanibas @kumavis Thoughts?

@danfinlay
Copy link

Auto approve my transactions within an X window of time. (to reduce the amount of tx over and over)

That one's scary, not sure I approve of it.

The rest is good.

Related to MetaMask/metamask-extension#3169

@cjeria
Copy link
Contributor Author

cjeria commented Mar 1, 2018

@danfinlay Yea, i wasn't sure of that one myself. I talked to someone at the retreat who expressed being annoyed with having to repeatedly approve transactions as he was developing his dapp on test nets. Thought I'd capture here so that I don't forget about it.

@danfinlay
Copy link

I think there are other ways for developers to improve that experience, like running Ganache locally.

@cjeria
Copy link
Contributor Author

cjeria commented Mar 1, 2018

Cool, didn't know that was possible with Ganache. Crossed that one out

image

@cjeria
Copy link
Contributor Author

cjeria commented Apr 25, 2018

I would add to the advanced settings a "display function data" switch.

We'll show function name on the top of a confirm TX screen by default for all transactions.
For example, a "Transfer" function type would look like this in the top bar:

image

However, if advanced users chooses to see additional data associated with the function type, they can turn on this feature in settings.

Example of what function data could look like:

 {
    name :'Transfer From',
    methodSignature: 'transferFrom( address, uint256 )`,
    args: [
      { type: 'address', value: '0xabcdefg1234567890 },
      { type: 'uint256', value: '235' }
    ]
  }

@danfinlay
Copy link

That looks like a huge improvement, I agree the parameters can probably be reserved for advanced users, and could even be captured on a separate issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants