Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add address-annotation permission SIP first draft #131

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

danfinlay
Copy link

Test driving this sip assistant gpt, forgive any errors. Getting the ball rolling on this general direction.

@danfinlay danfinlay requested review from Montoya, ziad-saab and a team as code owners January 22, 2024 23:28
SIPS/sip-x.md Outdated Show resolved Hide resolved
SIPS/sip-x.md Outdated Show resolved Hide resolved
SIPS/sip-x.md Outdated Show resolved Hide resolved
SIPS/sip-x.md Outdated Show resolved Hide resolved
@hmalik88
Copy link
Contributor

hmalik88 commented Jan 23, 2024

Started to review this but realized that the gist of what is in the doc is usable but also needs to be reformatted. I do think there are some design considerations here @eriknson. What components would we realistically want to expose for this functionality? Since there will be limited screen real estate for address insights, not sure how we allow for the snap to convey it's full insight without sacrificing our ui/ux.

danfinlay and others added 4 commits January 22, 2024 22:47
Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
@FrederikBolding
Copy link
Member

@hmalik88 I'm curious if we could build a more general purpose API for giving insights to a defined list of confirmation screen data. E.g. for both addresses, calldata, gasLimit, gasPrice etc.

Not sure if it should be a new form of transaction insight or something else 🤔

@hmalik88
Copy link
Contributor

hmalik88 commented Feb 19, 2024

@FrederikBolding But all of the other properties are essentially transaction data? Unless you mean that we should route the insights we get back to these specific components. I guess it would create for more of an inline experience. Wondering if we should modify the existing api to allow for this or create a new one hmm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants