-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add address-annotation permission SIP first draft #131
base: main
Are you sure you want to change the base?
Conversation
Started to review this but realized that the gist of what is in the doc is usable but also needs to be reformatted. I do think there are some design considerations here @eriknson. What components would we realistically want to expose for this functionality? Since there will be limited screen real estate for address insights, not sure how we allow for the snap to convey it's full insight without sacrificing our ui/ux. |
Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
@hmalik88 I'm curious if we could build a more general purpose API for giving insights to a defined list of confirmation screen data. E.g. for both addresses, calldata, gasLimit, gasPrice etc. Not sure if it should be a new form of transaction insight or something else 🤔 |
@FrederikBolding But all of the other properties are essentially transaction data? Unless you mean that we should route the insights we get back to these specific components. I guess it would create for more of an inline experience. Wondering if we should modify the existing api to allow for this or create a new one hmm... |
Test driving this sip assistant gpt, forgive any errors. Getting the ball rolling on this general direction.