SIP-28: Omitted timezone default to non-ambiguous UTC #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmalik88
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Yeah, I think I agree here. We should treat omitted timezone as UTC and all together not require the Z identifier. Quoting the wiki: "While it may be safe to assume local time when communicating in the same time zone, it is ambiguous when used in communicating across different time zones"
|
Something to consider would be to make the timezone required - this would reduce the likelihood of bugs arising due to incorrect implementations naively using (non-UTC) defaults in some library other than UTC, at the cost of making the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the timezone be ambiguous and open to interpretation is not ideal, IMO. Localtime can also be ambiguous. Hence I propose that when timezone information is not provided, the default is changed from localtime to UTC, and switching a
SHALLtoMUST.