Only tightly pack bytesN values

MetaMask · Oct 10, 2022 · bba5eb6 · bba5eb6
1 parent 03f8125
commit bba5eb6
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/parsers/array.test.ts b/src/parsers/array.test.ts
@@ -116,6 +116,22 @@ describe('array', () => {
       );
     });
 
+    it('tightly encodes a packed number array', () => {
+      expect(
+        bytesToHex(
+          array.encode({
+            type: 'uint256[]',
+            value: [BigInt(12), BigInt(34), BigInt(56), BigInt(78)],
+            buffer: new Uint8Array(),
+            packed: true,
+            tight: true,
+          }),
+        ),
+      ).toBe(
+        '0x000000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000000000220000000000000000000000000000000000000000000000000000000000000038000000000000000000000000000000000000000000000000000000000000004e',
+      );
+    });
+
     it('encodes a packed bytes1 array', () => {
       expect(
         bytesToHex(

diff --git a/src/parsers/array.ts b/src/parsers/array.ts
@@ -9,6 +9,7 @@ import { padStart } from '../utils';
 import { ParserError } from '../errors';
 import { Parser } from './parser';
 import { tuple } from './tuple';
+import { fixedBytes } from './fixed-bytes';
 
 const ARRAY_REGEX = /^(?<type>.*)\[(?<length>\d*?)\]$/u;
 
@@ -144,7 +145,7 @@ export const array: Parser<unknown[]> = {
         type: getTupleType(arrayType, fixedLength),
         buffer,
         value,
-        packed: tight,
+        packed: fixedBytes.isType(arrayType) && tight,
         tight,
       });
     }
@@ -156,7 +157,7 @@ export const array: Parser<unknown[]> = {
         types: new Array(value.length).fill(arrayType),
         values: value,
         byteArray: buffer,
-        packed: tight,
+        packed: fixedBytes.isType(arrayType) && tight,
         arrayPacked: true,
       });
     }