New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add `resolveAccountAddress` method + expose `SnapKeyring.submitRequest` #157

Merged

ccharly merged 18 commits into main from feat/resolve-account-address-and-public-submit-request

Jan 29, 2025

Collaborator

ccharly commented Jan 22, 2025 •

edited

Loading

The new SIP-26 requires some changes on the SnapKeyring and requires an additional keyring method to resolve account's address from a signing request.

ccharly commented

View reviewed changes

packages/keyring-api/src/api/caip.test.ts Outdated Show resolved Hide resolved

FrederikBolding reviewed

View reviewed changes

packages/keyring-api/src/api/caip.ts Outdated Show resolved Hide resolved

ccharly force-pushed the feat/resolve-account-address-and-public-submit-request branch from ed56e49 to 45dfb9f Compare

January 27, 2025 17:51

ccharly changed the title ~~feat: add resolveAccountAddress method~~ feat: add resolveAccountAddress method + expose SnapKeyring.submitRequest

danroc reviewed

View reviewed changes

packages/keyring-api/src/api/address.ts Outdated Show resolved Hide resolved

ccharly force-pushed the feat/resolve-account-address-and-public-submit-request branch from cb8359e to 8bc1d3f Compare

January 29, 2025 11:18

ccharly marked this pull request as ready for review

January 29, 2025 12:23

ccharly requested a review from a team as a code owner

January 29, 2025 12:23

danroc reviewed

View reviewed changes

packages/keyring-api/src/rpc.ts Show resolved Hide resolved

danroc reviewed

View reviewed changes

packages/keyring-api/src/api/keyring.ts Outdated Show resolved Hide resolved

danroc reviewed

View reviewed changes

packages/keyring-snap-bridge/src/SnapKeyring.ts Outdated Show resolved Hide resolved

danroc reviewed

View reviewed changes

packages/keyring-snap-bridge/src/SnapKeyring.ts Show resolved Hide resolved

danroc reviewed

View reviewed changes

packages/keyring-snap-bridge/src/SnapKeyring.ts Outdated Show resolved Hide resolved

danroc reviewed

View reviewed changes

packages/keyring-snap-bridge/src/SnapKeyring.ts Show resolved Hide resolved

ccharly and others added 16 commits

January 29, 2025 15:57


          feat: add resolveAccountAddress method

e611f25


          feat(keyring-snap-bridge): add SnapIdMap.hasSnapId method

88a3496


          feat(keyring-snap-bridge): add SnapKeyring.{hasSnapId,resolveAccountA…

abe1e33

…ddress} methods


          refactor(keyring-snap-bridge): moving #submitSnapRequest closer to #s…

eb5e984

…ubmitRequest


          feat(keyring-snap-bridge): add public submitRequest

045b6fa


          chore: better jsdoc

a9b8ef5


          chore: lint

0ea6969


          chore: re-remove CAIP files (after rebase)

6f38517


          refactor: snapID -> snapId

2449ac7


          chore: better comment

b2ac34d


          test: fix build

16fdd9b


          fix(keyring-api): fix resolveAccountAddress parameter type

98a9c57

Co-authored-by: Daniel Rocha <68558152+danroc@users.noreply.github.com>


          chore: typo

15ce4cf

Co-authored-by: Daniel Rocha <68558152+danroc@users.noreply.github.com>


          fix(keyring-api): add missing CaipChainId import

6633e0c


          test: fix error message

a303a96


          refactor(keyring-snap-bridge): re-use #submitSnapRequest for both sub…

50268a0

…mitRequest methods

ccharly force-pushed the feat/resolve-account-address-and-public-submit-request branch from c8a3555 to 50268a0 Compare

January 29, 2025 14:59


          refactor(keyring-snap-bridge): submitRequest: id -> account

7ac71e2

Collaborator Author

ccharly commented Jan 29, 2025

@metamaskbot publish-preview

github-actions bot commented Jan 29, 2025

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/keyring-api": "15.0.0-7ac71e2",
  "@metamask-previews/eth-hd-keyring": "9.0.1-7ac71e2",
  "@metamask-previews/eth-ledger-bridge-keyring": "8.0.3-7ac71e2",
  "@metamask-previews/eth-simple-keyring": "8.0.1-7ac71e2",
  "@metamask-previews/eth-trezor-keyring": "6.0.1-7ac71e2",
  "@metamask-previews/keyring-internal-api": "3.0.0-7ac71e2",
  "@metamask-previews/keyring-internal-snap-client": "3.0.1-7ac71e2",
  "@metamask-previews/eth-snap-keyring": "9.0.0-7ac71e2",
  "@metamask-previews/keyring-snap-client": "3.0.1-7ac71e2",
  "@metamask-previews/keyring-snap-sdk": "2.1.0-7ac71e2",
  "@metamask-previews/keyring-utils": "1.3.0-7ac71e2"
}

danroc previously approved these changes

View reviewed changes


          refactor: make resolveAccountAddress optional

15c087c

ccharly dismissed danroc’s stale review via

15c087c

January 29, 2025 16:40

danroc approved these changes

View reviewed changes

ccharly enabled auto-merge

January 29, 2025 16:43

ccharly added this pull request to the merge queue

Merged via the queue into main with commit 228c0b7

30 checks passed

ccharly deleted the feat/resolve-account-address-and-public-submit-request branch

January 29, 2025 16:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet