feat: use event payload type for emitSnapKeyringEvent
#203
+471
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
changed the title
emitSnapKeyringEvent
ccharly
force-pushed
the
feat/typed-emit-keyring-event
branch
3 times, most recently
from
d4f37e4 to
aa77804
Compare
ccharly
force-pushed
the
feat/typed-emit-keyring-event
branch
from
a5faeea to
2466e03
Compare
ccharly
force-pushed
the
feat/typed-emit-keyring-event
branch
from
2466e03 to
2a26eea
Compare
ccharly
force-pushed
the
feat/typed-emit-keyring-event
branch
from
2a26eea to
db4d703
Compare
danroc
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
emitSnapKeyringEventiss using a generic payload type (like aRecord<string, Json>). We were already usingsuperstructunder the hood to check that payload, but the error was then thrown at runtime.This new implementation allows to extract the actual payload type associated with the event to get errors at compile-time.