Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the ledger sign transaction issue due to this ethereumjs upgrade PR #253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dawnseeker8
Copy link
Contributor

@dawnseeker8 dawnseeker8 commented Mar 19, 2025

This PR will fix the ledger sign transaction issue due to this ethereumjs upgrade PR #209

and basically the ethereumjs upgrade code change make the transaction rawTxHex contain 0x prefix which is not valid for to @ledgerhq/hw-eth-app clearSignTransaction function. that functions expect a rawTxHex without 0x prefix.

…nTransaction which cause ledger library break.
@dawnseeker8 dawnseeker8 requested a review from a team as a code owner March 19, 2025 10:17
@dawnseeker8 dawnseeker8 changed the title fix: fix: fix the ledger sign transaction issue due to this ethereumjs upgrade PR Mar 19, 2025
@dawnseeker8
Copy link
Contributor Author

@metamaskbot publish-preview

@dawnseeker8 dawnseeker8 added the team-accounts This should be handled by the Accounts Team label Mar 19, 2025
Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/keyring-api": "17.2.1-9d37a15",
  "@metamask-previews/eth-hd-keyring": "12.1.0-9d37a15",
  "@metamask-previews/eth-ledger-bridge-keyring": "10.0.0-9d37a15",
  "@metamask-previews/eth-simple-keyring": "10.0.0-9d37a15",
  "@metamask-previews/eth-trezor-keyring": "8.0.0-9d37a15",
  "@metamask-previews/keyring-internal-api": "6.0.0-9d37a15",
  "@metamask-previews/keyring-internal-snap-client": "4.0.1-9d37a15",
  "@metamask-previews/eth-snap-keyring": "12.0.0-9d37a15",
  "@metamask-previews/keyring-snap-client": "4.0.1-9d37a15",
  "@metamask-previews/keyring-snap-sdk": "3.1.0-9d37a15",
  "@metamask-previews/keyring-utils": "3.0.0-9d37a15"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-accounts This should be handled by the Accounts Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant