fix: ledger iframe messages timeout #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesposito
changed the title
mikesposito
commented
Apr 1, 2025
mcmire
approved these changes
Apr 1, 2025
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
<!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? Are there any issues or other links reviewers should consult to understand this pull request better? For instance: * Fixes #12345 * See: #67890 --> #271 introduced timeouts for all messages between the Ledger bridge and the iframe. Though a 20-second timeout may not be enough for the user to grab the device and accept the request - especially if the user wants to look closely at the signature request on the hardware device. For this reason, the timeout is being removed for messages requiring user intervention, while keeping it for messages that do not expect user actions (i.e. `updateTransportMethod` and `attemptMakeApp`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ledger iframe messaging system is being refactored to be promise based instead of using callbacks. Moreover,
#sendMessagenow throws a timeout error when the message takes to long to get replied by the iframeRelated to #258