Revert "wallet_swapAsset v1" #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7296916.
mcmire
approved these changes
Feb 28, 2025
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
This is currently causing the e2e tests in MetaMask/metamask-extension#27782 to fail, so it would be great to revert this if this is indeed not ready.
7 tasks
vandan
approved these changes
Mar 1, 2025
Contributor
vandan
left a comment
vandan
left a comment
There was a problem hiding this comment.
Approving as well. I assume we can find this snippet to add back when the method is ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #201 due to
wallet_swapAssetnot being live yet.